Enable batchMode on scala.js Optimizer
#953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #951 |
| @@ -21,6 +21,7 @@ env: | |||
| global: | |||
| - secure: Kf44XQFpq2QGe3rn98Dsf5Uz3WXzPDralS54co7sqT5oQGs1mYLYZRYz+I75ZSo5ffZ86H7M+AI9YFofqGwAjBixBbqf1tGkUh3oZp2fN3QfqzazGV3HzC+o41zALG5FL+UBaURev9ChQ5fYeTtFB7YAzejHz4y5E97awk934Rg= | |||
| - secure: QbNAu0jCaKrwjJi7KZtYEBA/pYbTJ91Y1x/eLAJpsamswVOvwnThA/TLYuux+oiZQCiDUpBzP3oxksIrEEUAhl0lMtqRFY3MrcUr+si9NIjX8hmoFwkvZ5o1b7pmLF6Vz3rQeP/EWMLcljLzEwsrRXeK0Ei2E4vFpsg8yz1YXJg= | |||
| - botBuild=true | |||
There was a problem hiding this comment.
Does it matter that this is using = instead of :?
Edit: never mind I see what's going on here. 👍
The `batchMode` should help reduce the memory requirement to compile scala.js code as per scala-js/scala-js#1788 (comment) Implementation details: `botBuild` is a sbt setting that will be turned on on travisCi so that it will not interfere with local dev experience.
ngbinh
force-pushed
the
enable-scala.js-batchMode
branch
from
bfe8498
to
afc26ed
Compare
|
updated and squashed |
|
Should/does this change need to be in conjunction with the switch away from Rhino? Seems the builds still take a long time, upwards of an hour. |
|
ok, I will merge this PR into #954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
batchModeshould help reduce the memory requirement to compilescala.js code as per
scala-js/scala-js#1788 (comment)
Implementation details:
botBuildis a sbt setting that will be turnedon on travisCi so that it will not interfere with local dev experience.